GH-188 Add support for folia-based servers. #275
Conversation
# Conflicts: # buildSrc/src/main/kotlin/Versions.kt
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @vLuckyyy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the plugin's compatibility by adding robust support for Folia-based Minecraft servers. It achieves this through a new adaptive scheduling system that intelligently detects the server environment and utilizes the appropriate scheduler, alongside necessary dependency updates and build configuration adjustments to ensure seamless operation on both traditional Bukkit/Paper and modern Folia platforms.
Highlights
- Folia Server Support: Introduced support for Folia-based Minecraft servers by implementing an adaptive scheduler that dynamically selects between Bukkit and Folia scheduling mechanisms based on the server environment.
- Dependency Updates and Additions: Updated the
LITE_COMMANDSlibrary to version3.10.5and added new dependencies:litecommands-folia,eternalcode-commons-folia, andeternalcode-commons-sharedto facilitate Folia compatibility. - Scheduler Abstraction: Refactored the core scheduling logic by introducing a
MinecraftSchedulerinterface and an adaptiveCombatSchedulerAdapter, replacing directBukkitSchedulerImplusage across various services likeBorderServiceImpl,BorderTriggerIndex, andKnockbackService. - Build Configuration Enhancements: Modified the
build.gradle.ktsto explicitly declarefoliaSupported = trueand adjusted theshadowJarrelocation rule forio.papermctoio.papermc.lib.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces support for Folia-based servers by adding an adaptive scheduler, updating dependencies, and modifying task scheduling to be Folia-compatible. The approach is solid and correctly uses a runtime check to select the appropriate scheduler implementation. My review focuses on a potential high-severity issue in the knockback logic where a change made for Folia compatibility might lead to players being teleported into blocks. I've also included some medium-severity suggestions to improve the code quality of the new scheduler adapter class by adhering to common Java best practices for utility classes.
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/knockback/Point2D.java
Outdated
Show resolved
Hide resolved
eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatSchedulerAdapter.java
Outdated
Show resolved
Hide resolved
eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatSchedulerAdapter.java
Show resolved
Hide resolved
…atSchedulerAdapter.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/knockback/KnockbackService.java
Outdated
Show resolved
Hide resolved
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/knockback/Point2D.java
Outdated
Show resolved
Hide resolved
eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatSchedulerAdapter.java
Outdated
Show resolved
Hide resolved
…atSchedulerAdapter.java Co-authored-by: Jakub Kędziora <[email protected]>
No description provided.